We read every piece of feedback, and take your input very seriously.
To see all available qualifiers, see our documentation.
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Currently, the GreedyAlgorithm returns X_new_df with columns x1 and x2. See this part of the documentation, where the columns should be lat and lon:
GreedyAlgorithm
X_new_df
x1
x2
lat
lon
The relevant part of the code is here: https://github.com/tom-andersson/deepsensor/blob/e09f985a02ad79d1f5640173de6a9b2bc9587c27/deepsensor/active_learning/algorithms.py#L508
This should just require a one-line change to use self.x1_name and self.x2_name from here: https://github.com/tom-andersson/deepsensor/blob/e09f985a02ad79d1f5640173de6a9b2bc9587c27/deepsensor/active_learning/algorithms.py#L111-L112
self.x1_name
self.x2_name
I'll leave this open as a nice first issue for someone. Please add a unit test for this as well.
The text was updated successfully, but these errors were encountered:
Closed by #99
Sorry, something went wrong.
No branches or pull requests
Currently, the
GreedyAlgorithm
returnsX_new_df
with columnsx1
andx2
. See this part of the documentation, where the columns should belat
andlon
:The relevant part of the code is here:
https://github.com/tom-andersson/deepsensor/blob/e09f985a02ad79d1f5640173de6a9b2bc9587c27/deepsensor/active_learning/algorithms.py#L508
This should just require a one-line change to use
self.x1_name
andself.x2_name
from here: https://github.com/tom-andersson/deepsensor/blob/e09f985a02ad79d1f5640173de6a9b2bc9587c27/deepsensor/active_learning/algorithms.py#L111-L112I'll leave this open as a nice first issue for someone. Please add a unit test for this as well.
The text was updated successfully, but these errors were encountered: