Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Return active learning proposed placements with raw coordinate names #94

Closed
tom-andersson opened this issue Nov 8, 2023 · 1 comment
Labels
good first issue Good for newcomers

Comments

@tom-andersson
Copy link
Collaborator

Currently, the GreedyAlgorithm returns X_new_df with columns x1 and x2. See this part of the documentation, where the columns should be lat and lon:
image

The relevant part of the code is here:
https://github.com/tom-andersson/deepsensor/blob/e09f985a02ad79d1f5640173de6a9b2bc9587c27/deepsensor/active_learning/algorithms.py#L508

This should just require a one-line change to use self.x1_name and self.x2_name from here: https://github.com/tom-andersson/deepsensor/blob/e09f985a02ad79d1f5640173de6a9b2bc9587c27/deepsensor/active_learning/algorithms.py#L111-L112

I'll leave this open as a nice first issue for someone. Please add a unit test for this as well.

@tom-andersson
Copy link
Collaborator Author

Closed by #99

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
good first issue Good for newcomers
Projects
None yet
Development

No branches or pull requests

1 participant