Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

phone number validation for new users #2321

Open
5 tasks done
edchapman88 opened this issue Nov 28, 2024 · 0 comments
Open
5 tasks done

phone number validation for new users #2321

edchapman88 opened this issue Nov 28, 2024 · 0 comments
Labels
enhancement New functionality that should be added to the Safe Haven good first issue This is a good issue for newcomers to the project to tackle

Comments

@edchapman88
Copy link

✅ Checklist

  • I have searched open and closed issues for duplicates.
  • This is a request for a new feature in the Data Safe Haven or an upgrade to an existing feature.
  • The feature is still missing in the latest version.
  • I have read through the documentation.
  • This isn't an open-ended question (open a discussion if it is).

🍓 Suggested change

Add a lightweight (not too strict) phone number validation to the dsh users add command. To catch obvious user error early (e.g. number has too few or too many digits), before an Entra ID user is created.

🚂 How could this be done?

There is a PyPi package called phonenumbers that is a Python port of Google's libphonenumbers library. An error could be thrown by the dsh users add command is a phone number fails Google's validation.

@edchapman88 edchapman88 added the enhancement New functionality that should be added to the Safe Haven label Nov 28, 2024
@JimMadge JimMadge added the good first issue This is a good issue for newcomers to the project to tackle label Dec 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New functionality that should be added to the Safe Haven good first issue This is a good issue for newcomers to the project to tackle
Projects
None yet
Development

No branches or pull requests

2 participants