Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limit the variability of TextStyle in the gutter #260

Open
alexeyinkin opened this issue Nov 8, 2023 · 0 comments
Open

Limit the variability of TextStyle in the gutter #260

alexeyinkin opened this issue Nov 8, 2023 · 0 comments

Comments

@alexeyinkin
Copy link
Contributor

For the line numbers to be aligned with the code lines, they should share a lot of properties in TextStyle. This is because we use the natural vertical flow in the text field and in the gutter. We made two separate TextStyles for that to allow flexibility with color, weight, and other things, but the users repeatedly put different fonts, sizes, line spacing, etc. and expect the two to be aligned.

See:

We should:

  1. Inspect each property in TextStyle and see if different values in it break the alignment.
  2. For those properties breaking the alignment, take their values from CodeField.textStyle and force them in GutterStyle.textStyle.
  3. Document which properties in GutterStyle.textStyle have effect and are not overridden.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant