Hubspot to pubsub batch #8
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # dataflow/flex-templates/pom.xml
Amar3tto
reviewed
May 24, 2023
| <version>2.2.6</version> | ||
| </dependency> | ||
| </dependencies> | ||
| </project> |
Amar3tto
reviewed
May 24, 2023
| String getOutputTopic(); | ||
|
|
||
| void setOutputTopic(String outputTopic); | ||
| } |
Amar3tto
reviewed
May 24, 2023
| * limitations under the License. | ||
| */ | ||
|
|
||
| /** Cdap Salesforce template. */ |
Amar3tto
reviewed
May 24, 2023
| import org.slf4j.LoggerFactory; | ||
|
|
||
| /** | ||
| * HubspotToPubsub Pipeline. |
There was a problem hiding this comment.
Add description and example usage
Amar3tto
reviewed
May 24, 2023
| + "It will write a set of files with names like {prefix}-###.") | ||
| String getOutputTxtFilePathPrefix(); | ||
|
|
||
| void setOutputTxtFilePathPrefix(String outputTxtFilePathPrefix); |
There was a problem hiding this comment.
Not needed?
Because we don't output to txt
Amar3tto
reviewed
May 24, 2023
|
|
||
| @Validation.Required | ||
| @Description("Input .txt file path with Hubspot records.") | ||
| String getInputTxtFilePath(); |
There was a problem hiding this comment.
Not needed?
Because we don't read from txt
Amar3tto
reviewed
May 24, 2023
| * limitations under the License. | ||
| */ | ||
|
|
||
| /** Cdap Salesforce template. */ |
Amar3tto
reviewed
May 24, 2023
| * The {@link FormatOutput} wraps a String serializable messages with the {@link PubsubMessage} | ||
| * class. | ||
| */ | ||
| public static class FormatOutput extends PTransform<PCollection<String>, PDone> { |
There was a problem hiding this comment.
Maybe it will be better to move this out of FormatOutput class and make a method writeToPubsub(...)
Amar3tto
reviewed
May 24, 2023
| * limitations under the License. | ||
| */ | ||
|
|
||
| /** Cdap Salesforce template. */ |
Amar3tto
reviewed
May 24, 2023
| * limitations under the License. | ||
| */ | ||
|
|
||
| /** Cdap Salesforce template. */ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hubspot to pubsub batch has completed.