Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GitHub Actions #21

Open
akshitadixit opened this issue Jun 10, 2021 · 8 comments
Open

GitHub Actions #21

akshitadixit opened this issue Jun 10, 2021 · 8 comments
Assignees
@Yash-Sakre
Labels
🆘 help wanted This issue needs help ! Please help if possible ! 🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21.Points will be 25. LGMSOC21 This issue will be considered for LGM-SOC 21

Comments

@akshitadixit
Copy link
Owner

The greetings workflow needs to be fixed and act uniformly over all PRs
@akshitadixit akshitadixit added 🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21.Points will be 25. 🆘 help wanted This issue needs help ! Please help if possible ! LGMSOC21 This issue will be considered for LGM-SOC 21 labels Jun 10, 2021
@Yash-Sakre
Copy link
Contributor

I am LGM-SOC participant. I like to work on this issue. Please assign this issue to me.

@akshitadixit
Copy link
Owner Author

Sure @Yash-Sakre

@Yash-Sakre Yash-Sakre mentioned this issue Jun 11, 2021
Merged
@akshitadixit akshitadixit reopened this Jun 12, 2021
@akshitadixit
Copy link
Owner Author

@Yash-Sakre you want another try at this? It's still problematic.

@Yash-Sakre
Copy link
Contributor

Yash-Sakre commented Jun 12, 2021 •
edited
Loading

can you tell me what's the problem? Can I make a test issue for testing?

@akshitadixit
Copy link
Owner Author

Problems afaik:

  • Works fine with new issues
  • Doesn't work with new PRs see the latest example if you notice the username on line 12
  • For every PR which isn't a first time contribution, the check should still pass while doing nothing.

And yes you can create test issues/PRs for this.

@SamrendraS
Copy link
Collaborator

@Yash-Sakre Can you update me on the status of this issue?

@Yash-Sakre
Copy link
Contributor

I'll get back to you soon I'm a little busy because of the examination.

@Umesh-01
Copy link
Contributor

@akshitadixit should I work on this??

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Yash-Sakre Yash-Sakre

Labels
🆘 help wanted This issue needs help ! Please help if possible ! 🟧 Level3 This issue will be considered as level 3 issue for LGM-SOC 21.Points will be 25. LGMSOC21 This issue will be considered for LGM-SOC 21
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@SamrendraS @akshitadixit @Yash-Sakre @Umesh-01