Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

encoder_output isn't used in the RetNet decoder. #2

Open
Kimchangheon opened this issue Jan 23, 2024 · 1 comment
Open

encoder_output isn't used in the RetNet decoder. #2

Kimchangheon opened this issue Jan 23, 2024 · 1 comment

Comments

@Kimchangheon
Copy link

Hi, thanks for sharing your code! I'm also implementing an encoder-decoder model with a similar structure to yours.

However, I'm confused about why the encoder_output isn't used in the RetNet decoder. In my understanding, it should be fed directly or subjected to a cross-attention mechanism, similar to the original Transformer architecture. However, in your code, the encoder_output seems to be unused entirely.

@akshayatam
Copy link
Owner

Thanks for this issue. I am working on the fix. Apparently, the RetNet decoder does not have an argument for taking in the embeddings (see this post for more information). Being not very well acquainted with the model, I am trying to fix this for a more complete translation model.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants