-
Notifications
You must be signed in to change notification settings - Fork 80
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Allow nodes to be preprocessed #90
Conversation
2 similar comments
@aknuds1 Fixed the review comments. Please let me know if you have more feedback for this. |
@manixate Thanks for your contribution! I merged your changes via another branch so that I could make some revisions to it. Closing this PR as it's no longer necessary. I published a new version with the changes to NPM as v1.4.0 as well. |
@aknuds1 thanks for merging it. I checked the changes but I think it is doing something different. The idea behind preprocessing instructions was to let multiple instructions execute on the same node. That would have allowed to have smaller instruction sets for each node. e.g. a preprocessor to update all anchor tags, another to add specific ids to tags containing specific preprocess='true'. If an anchor tag contained preprocess='true' then the updates would depend on the order of instruction set because of The only way to get it do the above is to have multiple preprocessing instructions, 1 for anchor update, another for adding id and also another that checks both anchor and the attribute to do both things together too. |
This can help with sharing code to update the nodes based on a criteria before they are processed by individual processors.
Fixes: #38