New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Calculate fees in master signing client #426

Open

ygrishajev opened this issue Oct 29, 2024 · 0 comments

Contributor

ygrishajev commented Oct 29, 2024

While implementing billing features it was easier to have static fees value. It was forgotten and is still static https://github.com/akash-network/console/blob/main/apps/api/src/billing/services/master-signing-client/master-signing-client.service.ts#L138

We need look into this and properly calculate fees if it makes sense.

Acceptance criteria:

works for both uakt and usdc
performance is not heavily affected. This can be checked via present functional test

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment