Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clean API for adding executors #104

Open
whotwagner opened this issue Jul 30, 2024 · 1 comment
Open

Clean API for adding executors #104

whotwagner opened this issue Jul 30, 2024 · 1 comment
Assignees
Labels
enhancement New feature or request

Comments

@whotwagner
Copy link
Contributor

Currently adding an executor to attackmate is done in attackmate.py and it is necessary to initialize the executor(

def initialize_executors(self):
) and add the command-type to an endless list of a "for-statement" (
for command in commands:
). Make that more easier for developers to add executors and make the code more clear.

@whotwagner
Copy link
Contributor Author

I reopened this issue, because I still miss a couple of things. The purpose of this issue is, to make it as easy as possible for developers to create new executors. Currently it is necessary to create an executor, a schema for the correlating command and then the developer has to register the executor in that init.py and has to declare an initializer for the executor in attackmate.py and has to write an condition for the command-type to run the command with the correlating executor. I think we should brainstorm about possible solutions

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants