Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

BIP-85 derivation algorithm: unnecessary index limitation #217

Open
AnK26-616 opened this issue Oct 21, 2024 · 4 comments
Open

BIP-85 derivation algorithm: unnecessary index limitation #217

AnK26-616 opened this issue Oct 21, 2024 · 4 comments

Comments

@AnK26-616
Copy link

BIP85 based derivation algorithm is very useful not only for storing / deriving child wallet backup phrases but also for other solutions when the 12-24 word list can be used as a password to secure some secret. However the AirGap Vault (as of version 3.32.4) allows only to choose from the first 10 indexes (0-9). That is unnecessary limitation. It would be super useful if one could enter the index number simply by hand and then the app would derive the proper child mnemonic under given index. Is it possible to add that feature, please?

@AndreasGassmann
Copy link
Member

This limitation was added to prevent accidental misuse. Now that we have the advanced mode, I don't see any problem with allowing any kind of index.

@AnK26-616
Copy link
Author

You mean adding it under advance mode? That would be really great! As currently advanced mode allows only BIP-39 passphrases which is different thing than index (tbh way more important than index - but the compatibility between different tools is something I am trying to address with Air Gap Vault)

@AndreasGassmann
Copy link
Member

Yes. We can make it so that if you have advanced mode enabled, any kind of index can be used. Should we allow any index, or up to 2147483647?

@AnK26-616
Copy link
Author

Good question. Well... I am not sure if the effort to implement "any" really is worth spending. I would consider 32 bit integer at least - possibly with 64 bit integer limitation - 18446744073709551615- as the good "balance" between those two options (and also more future proof).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants
@AndreasGassmann @AnK26-616 and others