Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix pep8 errors? #5

Open
andriisoldatenko opened this issue Dec 28, 2018 · 1 comment
Open

Fix pep8 errors? #5

andriisoldatenko opened this issue Dec 28, 2018 · 1 comment

Comments

@andriisoldatenko
Copy link
Contributor

Right now I see lot's of pep8 errors:

  • E501 line too long
  • F401 'airflow.hooks.S3_hook.S3Hook' imported but unused
  • F821 undefined name 'colum'

what do you think if I PR it and fix?

best

flake8 .
./__init__.py:3:80: E501 line too long (94 > 79 characters)
./__init__.py:6:1: E302 expected 2 blank lines, found 1
./operators/snowflake_operator.py:1:1: F401 'airflow.hooks.S3_hook.S3Hook' imported but unused
./operators/snowflake_operator.py:2:1: F401 'airflow.plugins_manager.AirflowPlugin' imported but unused
./operators/snowflake_operator.py:5:1: F401 'io' imported but unused
./operators/snowflake_operator.py:6:1: F401 'jinja2.Template' imported but unused
./operators/snowflake_operator.py:8:1: E302 expected 2 blank lines, found 1
./operators/snowflake_operator.py:26:5: E303 too many blank lines (2)
./operators/snowflake_operator.py:31:1: W391 blank line at end of file
./operators/s3_to_snowflake_pipe_operator.py:4:1: F401 'airflow.version.version as airflow_version' imported but unused
./operators/s3_to_snowflake_pipe_operator.py:5:1: F401 'airflow.exceptions.AirflowException' imported but unused
./macros/snowflake_macro.py:2:22: E231 missing whitespace after ','
./macros/snowflake_macro.py:2:34: E231 missing whitespace after ','
./macros/snowflake_macro.py:2:80: E501 line too long (87 > 79 characters)
./macros/snowflake_macro.py:5:80: E501 line too long (136 > 79 characters)
./macros/snowflake_macro.py:24:56: F821 undefined name 'colum'
./macros/snowflake_macro.py:25:54: E231 missing whitespace after ','
./macros/snowflake_macro.py:26:12: E225 missing whitespace around operator
./macros/snowflake_macro.py:26:68: E231 missing whitespace after ','
./macros/snowflake_macro.py:33:1: W391 blank line at end of file
./hooks/snowflake_hook.py:60:80: E501 line too long (87 > 79 characters)
./hooks/snowflake_hook.py:61:80: E501 line too long (148 > 79 characters)
./hooks/snowflake_hook.py:62:80: E501 line too long (146 > 79 characters)
./hooks/snowflake_hook.py:63:80: E501 line too long (137 > 79 characters)
./hooks/snowflake_hook.py:64:80: E501 line too long (145 > 79 characters)
./hooks/snowflake_hook.py:65:80: E501 line too long (141 > 79 characters)
./hooks/snowflake_hook.py:98:80: E501 line too long (87 > 79 characters)
./hooks/snowflake_hook.py:100:80: E501 line too long (147 > 79 characters)
./hooks/snowflake_hook.py:101:80: E501 line too long (145 > 79 characters)
./hooks/snowflake_hook.py:102:80: E501 line too long (136 > 79 characters)
./hooks/snowflake_hook.py:103:80: E501 line too long (144 > 79 characters)
./hooks/snowflake_hook.py:104:80: E501 line too long (140 > 79 characters)
@andriisoldatenko
Copy link
Contributor Author

PR here #6

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant