Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Should client_id, client_secret, and tenant_id be sensitive values for airbyte_source_bing_ads? #110

Open
anzelpwj-rev opened this issue Jun 10, 2024 · 0 comments

Comments

@anzelpwj-rev
Copy link

Hi everyone,

I'm doing some initial setup with migrating our Airbyte infrastructure to Terraform, and when I tried testing a BingAds connector, I got the following:

  # airbyte_source_bing_ads.source_bingads will be created
  + resource "airbyte_source_bing_ads" "source_bingads" {
      + configuration = {
          + client_id          = "xyz"
          + client_secret      = "xyz"
          + developer_token    = (sensitive value)
          + lookback_window    = 0
          + refresh_token      = (sensitive value)
          + reports_start_date = "2024-01-01"
          + tenant_id          = "xyz"
        }
      + name          = "BingAds_Dev"
      + source_id     = (known after apply)
      + source_type   = (known after apply)
      + workspace_id  = "86835965-503b-43b6-ab6b-c25e0d606f11"
    }

client_id, client_secret, and tenant_id are obscured in the Airbyte UI, so I'm curious why they are not considered sensitive (especially client_secret) for the configuration.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant