Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Private job image registry support #16968

Open
cloorc opened this issue Sep 21, 2022 · 4 comments
Open

Private job image registry support #16968

cloorc opened this issue Sep 21, 2022 · 4 comments
Labels
area/platform issues related to the platform autoteam community frozen Not being actively worked on team/platform-hold team/platform-move type/enhancement New feature or request

Comments

@cloorc
Copy link

cloorc commented Sep 21, 2022

Tell us about the problem you're trying to solve

We are hosting our own private docker image registry (Harbor). We need specify private registry for all possible source/target images. However, I can only specify the imagePullSecrets but not able to change all images' registry from configration of workers.

Describe the solution you’d like

Can specify an additional private registry besides image pull secrets like this:

airbyte:
  worker:
    job:
      kube:
        main:
          container:
            image-registry: ${JOB_KUBE_MAIN_CONTAINER_IMAGE_REGISTRY:}
            image-pull-policy: ${JOB_KUBE_MAIN_CONTAINER_IMAGE_PULL_POLICY:IfNotPresent}
            image-pull-secret: ${JOB_KUBE_MAIN_CONTAINER_IMAGE_PULL_SECRET:}

Describe the alternative you’ve considered or used

We've just changed the ProcessFactory implementation to support this.

Additional context

None.

Are you willing to submit a PR?

I've updated the implementation of ProcessFactory to support this.

@cloorc cloorc added needs-triage type/enhancement New feature or request labels Sep 21, 2022
@harshithmullapudi harshithmullapudi added area/platform issues related to the platform and removed needs-triage team/tse Technical Support Engineers labels Sep 21, 2022
@harshithmullapudi
Copy link
Contributor

Hey this implementation you are suggesting, can you help us make a PR and so that team can look into it?

@salima-airbyte
Copy link

@andyjih: need your thoughts on this.

@cloorc
Copy link
Author

cloorc commented Sep 22, 2022

Hey this implementation you are suggesting, can you help us make a PR and so that team can look into it?

Yes, a pull request about this enhancement is already submitted as :

#16969

@andyjih
Copy link
Contributor

andyjih commented Sep 26, 2022

@davinchia Is this something you might have some thoughts or context on?

@bleonard bleonard added the frozen Not being actively worked on label Mar 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area/platform issues related to the platform autoteam community frozen Not being actively worked on team/platform-hold team/platform-move type/enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

7 participants