Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Avoid hardcoding file paths in _is_local_manifest_command #59

Open
coderabbitai bot opened this issue Nov 15, 2024 · 0 comments
Open

Avoid hardcoding file paths in _is_local_manifest_command #59

coderabbitai bot opened this issue Nov 15, 2024 · 0 comments
Assignees
@aaronsteers

Comments

@coderabbitai
Copy link
Contributor

coderabbitai bot commented Nov 15, 2024

In the _is_local_manifest_command function, the path to the manifest.yaml is hardcoded as "/airbyte/integration_code/source_declarative_manifest/manifest.yaml". It would be beneficial to derive this path dynamically or make it configurable to improve portability, especially if the directory structure changes in the future.

Reference:

Requested by: @aaronsteers
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@aaronsteers aaronsteers

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@aaronsteers