Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[airbyte-protocol]: Add support for Pydantic v2, with backward-compatible test for Pydantic v1 #76

Closed
aaronsteers opened this issue May 7, 2024 · 1 comment
Assignees

Comments

@aaronsteers
Copy link

aaronsteers commented May 7, 2024

This library (airbyte-protocol-models) is depended upon by the Python CDK, which is depended upon by PyAirbyte, which is depended upon by user environments with a variety of other installed libraries.

Users have asked to relax the Pydantic requirement so we can allow PyAirbyte in environments that also need Pydantic 2.0 (directly or by transitive dependencies).

Proposed actions:

  1. Relax the Pydantic version constraints to allow Pydantic 2.0.
  2. Add a CI test matrix to ensure we're validating successful execution in 1.x as well as 2.x.
  3. Repeat this process on the CDK, and then also in PyAirbyte:
    1. [cdk] Upgrade Airbyte and its dependencies to Pydantic V2 airbyte#36475
    2. Support of Pydantic v2  PyAirbyte#216

Migration guide is here: https://docs.pydantic.dev/latest/migration/

@aaronsteers aaronsteers self-assigned this May 7, 2024
@aaronsteers aaronsteers changed the title Add support for Pydantic v2, with backward-compatible test for Pydantic v1 [airbyte-protocol]: Add support for Pydantic v2, with backward-compatible test for Pydantic v1 May 7, 2024
@aaronsteers
Copy link
Author

aaronsteers commented Jun 21, 2024

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant