From 912eec5ce67ec21182477b8d05ff46f7d7ce2a40 Mon Sep 17 00:00:00 2001 From: benmoriceau Date: Mon, 1 Apr 2024 16:42:07 -0700 Subject: [PATCH] PR comments --- .../airbyte_protocol/airbyte_protocol.yaml | 21 ++++++++++++++----- .../airbyte_protocol/v0/airbyte_protocol.yaml | 2 +- 2 files changed, 17 insertions(+), 6 deletions(-) diff --git a/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml b/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml index 6e299e9..6fc1e7d 100644 --- a/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml +++ b/protocol-models/src/main/resources/airbyte_protocol/airbyte_protocol.yaml @@ -463,8 +463,6 @@ definitions: - stream - sync_mode - destination_sync_mode - - generation_id - - sync_id properties: stream: "$ref": "#/definitions/AirbyteStream" @@ -487,13 +485,26 @@ definitions: items: type: string generation_id: - description: Monotically increasing numeric id representing the current generation of a stream. This id can be shared across syncs + description: + "Monotically increasing numeric id representing the current generation of a stream. This id can be shared across syncs. + + If this is null, it means that the platform is not supporting the refresh and it is expected that no extra id will be added to the records and no data from previous generation will be cleanup. + " type: integer minimum_generation_id: - description: The minimum generation id which is needed in a stream. If it is present, the destination will try to delete the data that are part of a generation lower than this property. If it is absent, the destination won't try to delete data + description: + "The minimum generation id which is needed in a stream. If it is present, the destination will try to delete the data that are part of a generation lower than this property. + If the minimum generation is equals to 0, no data deletion is expected from the destiantion + + If this is null, it means that the platform is not supporting the refresh and it is expected that no extra id will be added to the records and no data from previous generation will be cleanup. + " type: integer sync_id: - description: Monotically increasing numeric id representing the current sync id. This is aimed to be unique per sync. + description: + "Monotically increasing numeric id representing the current sync id. This is aimed to be unique per sync. + + If this is null, it means that the platform is not supporting the refresh and it is expected that no extra id will be added to the records and no data from previous generation will be cleanup. + " type: integer SyncMode: type: string diff --git a/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml b/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml index 3918002..2416153 100644 --- a/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml +++ b/protocol-models/src/main/resources/airbyte_protocol/v0/airbyte_protocol.yaml @@ -464,7 +464,7 @@ definitions: - stream - sync_mode - destination_sync_mode - - current_generation_id + - generation_id - sync_id properties: stream: