Fix incorrect usage of Go templating #351
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
The usage of Go templating (
index
function more specifically) was incorrect in recent releases.Instead of populating configmap items
CONTAINER_ORCHESTRATOR_IMAGE
,WORKLOAD_INIT_IMAGE
andCONNECTOR_SIDECAR_IMAGE
with the right value from their respectiveimage
field, the helm chart populates them asnull
, which is incorrect. From Go documentation,This fix has solved the problem for me locally
How
The fix replaces incorrect usage of
index
with nested indices separated by spacesRecommended reading order
x.kt
y.kt
Can this PR be safely reverted and rolled back?