Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix incorrect usage of Go templating #351

Closed
wants to merge 3 commits into from
Closed

Conversation

XIAZY
Copy link
Contributor

@XIAZY XIAZY commented Aug 21, 2024

What

The usage of Go templating (index function more specifically) was incorrect in recent releases.

Instead of populating configmap items CONTAINER_ORCHESTRATOR_IMAGE, WORKLOAD_INIT_IMAGE and CONNECTOR_SIDECAR_IMAGE with the right value from their respective image field, the helm chart populates them as null, which is incorrect. From Go documentation,

index
Returns the result of indexing its first argument by the
following arguments. Thus "index x 1 2 3" is, in Go syntax,
x[1][2][3]. Each indexed item must be a map, slice, or array.

This fix has solved the problem for me locally

How

The fix replaces incorrect usage of index with nested indices separated by spaces

Recommended reading order

  1. x.kt
  2. y.kt

Can this PR be safely reverted and rolled back?

  • YES 💚
  • NO ❌

@CLAassistant
Copy link

CLAassistant commented Aug 21, 2024

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
1 out of 2 committers have signed the CLA.

✅ XIAZY
❌ perangel
You have signed the CLA already but the status is still pending? Let us recheck it.

@marcosmarxm
Copy link
Member

@XIAZY sorry the delay to review your contribution.
@perangel and @abuchanan-airbyte can you check this?

@perangel
Copy link
Contributor

/create-oss-pr

@marcosmarxm
Copy link
Member

@marcosmarxm marcosmarxm closed this Oct 2, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants