Fix opening non default workspace in webapp #322
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The problem was that opening the webapp to a workspace id that was not the default worksapce id was failing with the `Invalid RBAC query` error. It seems like it was introduced in this change: airbytehq@61079f5#diff-aa38ef9df589b86ae09c4ac9c1653be68a79ed26c07dcb0a75d641de00c99b03R22-R26 Simply reverting the extra check that was added seems to fix the issue.
|
|
|
We're seeing this as well in the latest builds & helm charts. Would be great to get this merged! Thank you! |
|
@timroes since he looks like the original commiter of the change @nathanseal mentioned |
|
Hi, the issue is solved from version v0.57.4 onwards. Please upgrade to that version to fix the issue. Background: Every workspace should be in an organization (data model wise) by now, and that it wasn't (in the OSS version) was due to some issues, which have now been addressed. The code in question here in this PR (specifically: the exception that there wouldn't be an organization) will be removed soon completely. |
|
Thanks @timroes! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The problem was that opening the webapp to a workspace id that was not the default worksapce id was failing with the
Invalid RBAC queryerror.It seems like it was introduced in this change:
61079f5#diff-aa38ef9df589b86ae09c4ac9c1653be68a79ed26c07dcb0a75d641de00c99b03R22-R26
Simply reverting the extra check that was added seems to fix the issue.
What
How
Recommended reading order
x.kty.ktCan this PR be safely reverted and rolled back?