Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

update minio helm template to maintain logs when it restarted #290

Closed
wants to merge 4 commits into from

Conversation

jx2lee
Copy link
Contributor

@jx2lee jx2lee commented Nov 25, 2023

What

resolve #27750

How

if u want to maintain minio logs when restarted, set minio.storage.persistence true

Recommended reading order

Null

Can this PR be safely reverted / rolled back?

If you know that your PR is backwards-compatible and can be simply reverted or rolled back, check the YES box.

Otherwise if your PR has a breaking change, like a database migration for example, check the NO box.

If unsure, leave it blank.

  • YES 💚
  • NO ❌

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

@jx2lee jx2lee marked this pull request as ready for review November 25, 2023 15:36
Copy link

sonarqubecloud bot commented Dec 2, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@colesnodgrass colesnodgrass self-assigned this Dec 7, 2023
@colesnodgrass
Copy link
Member

/create-oss-pr

@colesnodgrass
Copy link
Member

Rather than add the ability to set a persistence flag, I updated the mountPath to match the path we actually write to (storage). The /data path was a bug. This also fixes an issue (one of many) with deploying to OpenShift.

@jx2lee
Copy link
Contributor Author

jx2lee commented Dec 8, 2023

Great, i checked update and will close this PR

@jx2lee jx2lee closed this Dec 8, 2023
@jx2lee jx2lee deleted the persistence-minio branch December 8, 2023 04:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Helm: previous job-logging removed when minio pod restarting
3 participants