Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Make NGNIX unprivileged docker images as default #289

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

nexcalmart
Copy link

What

To support non-root deployments on k8s NGINX has to be configured to work without root privileges.
There is already an official docker image of NGINX in an unprivileged mode.
Since the webapp doesn't need privileged access rights this has to be taken as the default docker image for the webapp.

How

Change the build configuration to switch to the non-privileged docker image if not explicitly overwritten by the env variable.

Recommended reading order

1-

Can this PR be safely reverted / rolled back?

  • [ X ] YES 💚
  • NO ❌

🚨 User Impact 🚨

No

Copy link
Contributor

github-actions bot commented Dec 1, 2023

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

Copy link

sonarqubecloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.7% 0.7% Duplication

@nexcalmart nexcalmart force-pushed the nexcalmart/nginx-unprivileged branch from 59db2bb to d175db6 Compare March 4, 2024 15:47
Copy link
Contributor

github-actions bot commented Mar 4, 2024

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

@colesnodgrass
Copy link
Member

@perangel This PR should be closed out by your work.

Copy link
Contributor

github-actions bot commented Mar 7, 2024

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

@nexcalmart nexcalmart force-pushed the nexcalmart/nginx-unprivileged branch from d175db6 to 6446c83 Compare March 8, 2024 14:05
Copy link

sonarqubecloud bot commented Mar 8, 2024

Quality Gate Failed Quality Gate failed

Failed conditions
3.4% Duplication on New Code (required ≤ 3%)

See analysis details on SonarCloud

Copy link
Contributor

github-actions bot commented Mar 8, 2024

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants