Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix extraContainers in Cron helm chart #272

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

nightmareartist
Copy link
Contributor

What

If current chart is used with extraContainers enabled the deployment will fail with the following error message:

Error: YAML parse error on cron/templates/deployment.yaml: error converting YAML to JSON: yaml: line 94: did not find expected key

This is not a problem when global extraContainers is used, but if, for example, we want Cron specific sidecar containers the setup will fail.

How

Added proper indentation to line 154.

Can this PR be safely reverted / rolled back?

If unsure, leave it blank.

  • [X ] YES 💚
  • NO ❌

🚨 User Impact 🚨

None.

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@PurseChicken
Copy link

This is still an active issue. Could we please get this merged in and fixed? The proposed change from nindent 6 to nindent 8 is valid.

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants