Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Double the size of the buffer used to read connector specs #249

Closed
wants to merge 2 commits into from

Conversation

cjwooo
Copy link
Contributor

@cjwooo cjwooo commented Jun 7, 2023

What

We have some custom connectors whose specs exceed Airbyte's maximum allowed spec size.

How

Double the size of the spec buffer.

Recommended reading order

  1. x.java
  2. y.java

Can this PR be safely reverted / rolled back?

If you know that your PR is backwards-compatible and can be simply reverted or rolled back, check the YES box.

Otherwise if your PR has a breaking change, like a database migration for example, check the NO box.

If unsure, leave it blank.

  • YES 💚
  • NO ❌

🚨 User Impact 🚨

Are there any breaking changes? What is the end result perceived by the user? If yes, please merge this PR with the 🚨🚨 emoji so changelog authors can further highlight this if needed.

@cjwooo
Copy link
Contributor Author

cjwooo commented Jun 8, 2023

@marcosmarxm Can you help with enabling the remaining GitHub Actions Workflows to run on this pull request?

@davinchia davinchia requested a review from gosusnp July 18, 2023 00:18
@gosusnp
Copy link
Contributor

gosusnp commented Jul 18, 2023

@marcosmarxm, what happened to https://github.com/airbytehq/airbyte-platform-internal/pull/6505, it was supposed to be the clean fix for this.

@cjwooo
Copy link
Contributor Author

cjwooo commented Aug 25, 2023

Bump

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

@cjwooo cjwooo closed this May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants