Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support existing secrets for aws creds #237

Closed
wants to merge 2 commits into from

Conversation

sh4sh
Copy link
Contributor

@sh4sh sh4sh commented May 5, 2023

What

Partially addresses airbytehq/airbyte#22529
There are helm values to override AWS_SECRET_ACCESS_KEY and AWS_ACCESS_KEY_ID with existing secrets, but at the moment they don't seem to work. I added some logic to support these values.

Can this PR be safely reverted / rolled back?

If you know that your PR is backwards-compatible and can be simply reverted or rolled back, check the YES box.

Otherwise if your PR has a breaking change, like a database migration for example, check the NO box.

If unsure, leave it blank.

  • YES 💚
  • NO ❌

@github-actions
Copy link
Contributor

github-actions bot commented May 5, 2023

Airbyte Code Coverage

There is no coverage information present for the Files changed

Total Project Coverage 27.67% 🍏

@CLAassistant
Copy link

CLA assistant check
Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
You have signed the CLA already but the status is still pending? Let us recheck it.

Copy link
Contributor

github-actions bot commented May 7, 2024

Your branch is not currently up-to-date with main. Please update your branch before attempting to snapshot your PR.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants