From d7a42d3670799ef54977ce73581f0c3f553591de Mon Sep 17 00:00:00 2001 From: "Aaron (\"AJ\") Steers" Date: Tue, 30 Jul 2024 22:29:42 -0700 Subject: [PATCH] Fix: Default to docker-based destination executors (#322) --- airbyte/_executors/util.py | 2 +- airbyte/destinations/util.py | 7 ++++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/airbyte/_executors/util.py b/airbyte/_executors/util.py index a3ce13e4..ab4236e9 100644 --- a/airbyte/_executors/util.py +++ b/airbyte/_executors/util.py @@ -31,7 +31,7 @@ def get_connector_executor( # noqa: PLR0912, PLR0913, PLR0915 # Too complex version: str | None = None, pip_url: str | None = None, local_executable: Path | str | None = None, - docker_image: bool | str = False, + docker_image: bool | str | None = False, use_host_network: bool = False, source_manifest: bool | dict | Path | str = False, install_if_missing: bool = True, diff --git a/airbyte/destinations/util.py b/airbyte/destinations/util.py index 59b1354e..3fff4924 100644 --- a/airbyte/destinations/util.py +++ b/airbyte/destinations/util.py @@ -23,7 +23,7 @@ def get_destination( version: str | None = None, pip_url: str | None = None, local_executable: Path | str | None = None, - docker_image: str | bool = False, + docker_image: str | bool | None = None, install_if_missing: bool = True, ) -> Destination: """Get a connector by name and version. @@ -50,6 +50,11 @@ def get_destination( install_if_missing: Whether to install the connector if it is not available locally. This parameter is ignored when local_executable is set. """ + if not pip_url and not local_executable: + # Destination connectors are not yet published to PyPI. + # Default to Docker-based execution if no other method is explicitly requested. + docker_image = docker_image or True + return Destination( name=name, config=config,