Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(docs):Make the ts-migrate able to execute #202

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Prakhargarg-2010196
Copy link

@Prakhargarg-2010196 Prakhargarg-2010196 commented Jun 30, 2023

The ts-migrate produced errors for npm or npx when used with run command as it didn't used the local or remote repository for execution.Fixed the problem using "npm exec" command which is used for running local scripts installed at dependency level.

image

This will fix issue #201 I guess.

The ts-migrate produced errors for npm or npx when used with run command as it didn't
used the local or remote repository for execution.Fixed the problem using "npm exec" command which is used
for running local scripts installed at dependency level.
Copy link
Author

@Prakhargarg-2010196 Prakhargarg-2010196 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have tested each command specifically for correct usage.

@Prakhargarg-2010196
Copy link
Author

Prakhargarg-2010196 commented Jun 30, 2023

@Rudeg and @edsrzf Please review this!!

@Prakhargarg-2010196
Copy link
Author

The ts-migrate produced errors for npm or npx when used with run command as it didn't used the local or remote repository for execution.Fixed the problem using "npm exec" command which is used for running local scripts installed at dependency level.

image

Copy link

@asttle-vuram asttle-vuram left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change worked for me! Since there is no script for ts-migrate exec will create the file

@Prakhargarg-2010196
Copy link
Author

I guess review must be done by a person with write access to make merging acceptable

@diondiondion
Copy link

Thanks for this PR @Prakhargarg-2010196, I was stuck and puzzled about how to run the script until I found it. Would be great if the maintainers could get this merged.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants