Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added hindi language in pluralization rules in index.js file #182

Closed
wants to merge 1 commit into from

Conversation

anirudh-hegde
Copy link

No description provided.

Copy link
Collaborator

@ljharb ljharb left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! There’ll be some linter changes, but also we’d need tests.

@ljharb ljharb marked this pull request as draft December 2, 2023 16:25
Copy link
Author

@anirudh-hegde anirudh-hegde left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think code is correct

@anirudh-hegde anirudh-hegde marked this pull request as ready for review December 3, 2023 02:38
@ljharb
Copy link
Collaborator

ljharb commented Dec 3, 2023

Code can’t be correct if there’s no tests to keep it so :-)

@ljharb ljharb marked this pull request as draft December 3, 2023 02:44
@anirudh-hegde
Copy link
Author

Code can’t be correct if there’s no tests to keep it so :-)

I will try to add tests :-)

@ljharb
Copy link
Collaborator

ljharb commented Dec 8, 2023

@anirudh-hegde are you no longer interested in completing this PR?

@anirudh-hegde
Copy link
Author

To be frank I don't know how to add tests

@ljharb
Copy link
Collaborator

ljharb commented Dec 8, 2023

To this file https://github.com/airbnb/polyglot.js/blob/master/test/index.js you can add a few test cases with hindi, showing that pluralization is handled correctly.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants