Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong string for pt-BR locale #139

Open
lcneves opened this issue Nov 14, 2019 · 2 comments · May be fixed by #186
Open

Wrong string for pt-BR locale #139

lcneves opened this issue Nov 14, 2019 · 2 comments · May be fixed by #186
Labels
bug pull request wanted

Comments

@lcneves
Copy link

lcneves commented Nov 14, 2019

index.js, line 102:
french: ['fr', 'tl', 'pt-br'],

Should be:
french: ['fr', 'tl', 'pt-BR'],
@ljharb
Copy link
Collaborator

ljharb commented Nov 14, 2019

cc @schleyfox to confirm that we don't need to keep both capitalizations

@schleyfox
Copy link
Contributor

I don't think we do any handling of the locales that are passed in that would make this case insensitive, so changing the capitalization could be breaking. You'd probably need both capitalizations.

likeavirgil added a commit to likeavirgil/polyglot.js that referenced this issue Jun 29, 2021
@likeavirgil
Fix airbnb#139: Add normalized locale fo pt-BR
e3370f3
likeavirgil added a commit to likeavirgil/polyglot.js that referenced this issue Jun 29, 2021
@likeavirgil
Fix airbnb#139: Add normalized locale for pt-BR
f476ce7
likeavirgil added a commit to likeavirgil/polyglot.js that referenced this issue May 31, 2022
@likeavirgil
Fix airbnb#139: Add normalized locale for pt-BR
f87990b
@ljharb ljharb linked a pull request Dec 4, 2024 that will close this issue
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug pull request wanted
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

solves issue #139 pushkar707/polyglot.js
3 participants
@schleyfox @ljharb @lcneves