Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] Populate each service's data separately #50

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from 3 commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

<groupId>com.airbnb.billow</groupId>
<artifactId>billow</artifactId>
<version>2.21</version>
<version>2.22</version>

<licenses>
<license>
Expand Down Expand Up @@ -207,8 +207,8 @@
<artifactId>maven-compiler-plugin</artifactId>
<version>${maven-compiler-plugin.version}</version>
<configuration>
<source>1.7</source>
<target>1.7</target>
<source>8</source>
<target>8</target>
</configuration>
</plugin>
</plugins>
Expand Down
274 changes: 176 additions & 98 deletions src/main/java/com/airbnb/billow/AWSDatabase.java

Large diffs are not rendered by default.

78 changes: 69 additions & 9 deletions src/main/java/com/airbnb/billow/AWSDatabaseHolder.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.airbnb.billow;

import com.google.common.collect.ImmutableList;
import lombok.Getter;
import lombok.extern.slf4j.Slf4j;

Expand Down Expand Up @@ -124,17 +125,76 @@ public AWSDatabaseHolder(Config config) {
rebuild();
}

/**
* Build a fresh version of the DB completely from scratch
*/
public void rebuild() {
current = new AWSDatabase(
ec2Clients,
rdsClients,
dynamoDBClients,
sqsClients,
elasticacheClients,
elasticsearchClients,
iamClient,
awsAccountNumber,
awsARNPartition);
ec2Clients,
rdsClients,
dynamoDBClients,
sqsClients,
elasticacheClients,
elasticsearchClients,
iamClient,
awsAccountNumber,
awsARNPartition);
}

/**
* Incrementally refresh ec2 instance data
*/
public void refreshEc2Instances() {
current.refreshEc2Instances(ec2Clients);
}

/**
* Incrementally refresh dyanmo data
*/
public void refreshDynamoTables() {
current.refreshDynamoTables(dynamoDBClients);
}

/**
* Incrementally refresh rds instance data
*/
public void refreshRdsInstances() {
current.refreshRdsInstances(rdsClients);
}

/**
* Incrementally refresh EC2 security group data
*/
public void refreshEc2SGs() {
current.refreshEc2SGs(ec2Clients);
}

/**
* Incrementally refresh sqs data
*/
public void refreshSqsQueues() {
current.refreshSqsQueues(sqsClients);
}

/**
* Incrementally refresh elasticache data
*/
public void refreshElasticacheClusters() {
current.refreshElasticacheClusters(elasticacheClients);
}

/**
* Incrementally refresh IAM data
*/
public void refreshIamUsers() {
current.refreshIamUsers(iamClient);
}

/**
* Incrementally refresh elasticsearch data
*/
public void refreshElasticsearchClusters() {
current.refreshElasticsearchClusters(elasticsearchClients);
}

public HealthCheck.Result healthy() {
Expand Down
42 changes: 28 additions & 14 deletions src/main/java/com/airbnb/billow/Main.java
Original file line number Diff line number Diff line change
@@ -1,5 +1,6 @@
package com.airbnb.billow;

import com.airbnb.billow.jobs.*;
import com.codahale.metrics.CachedGauge;
import com.codahale.metrics.Gauge;
import com.codahale.metrics.MetricRegistry;
Expand All @@ -22,6 +23,7 @@
import org.eclipse.jetty.servlet.ServletHolder;
import org.quartz.JobDetail;
import org.quartz.Scheduler;
import org.quartz.SchedulerException;
import org.quartz.SimpleTrigger;
import org.quartz.impl.StdSchedulerFactory;

Expand Down Expand Up @@ -71,23 +73,21 @@ protected Long loadValue() {
metricRegistry.register(databaseAgeMetricName, cacheAgeGauge);

final Scheduler scheduler = StdSchedulerFactory.getDefaultScheduler();
scheduler.getContext().put(AWSDatabaseHolderRefreshJob.DB_KEY, dbHolder);
scheduler.getContext().put(AWSDatabaseHolderRefreshJob.START_COUNTER_KEY, metricRegistry.counter(jobStartMetricName));
scheduler.getContext().put(AWSDatabaseHolderRefreshJob.FAILURE_COUNTER_KEY, metricRegistry.counter(jobFailureMetricName));
scheduler.getContext().put(AWSDatabaseHolderRefreshJob.SUCCESS_COUNTER_KEY, metricRegistry.counter(jobSuccessMetricName));
scheduler.getContext().put(BaseAWSDatabaseHolderRefreshJob.DB_KEY, dbHolder);
scheduler.getContext().put(BaseAWSDatabaseHolderRefreshJob.START_COUNTER_KEY, metricRegistry.counter(jobStartMetricName));
scheduler.getContext().put(BaseAWSDatabaseHolderRefreshJob.FAILURE_COUNTER_KEY, metricRegistry.counter(jobFailureMetricName));
scheduler.getContext().put(BaseAWSDatabaseHolderRefreshJob.SUCCESS_COUNTER_KEY, metricRegistry.counter(jobSuccessMetricName));
scheduler.start();

final SimpleTrigger trigger = newTrigger().
withIdentity(AWSDatabaseHolderRefreshJob.NAME).
startNow().
withSchedule(simpleSchedule().withIntervalInMilliseconds(refreshRate).repeatForever()).
build();
scheduleJob(scheduler, DynamoRefreshJob.class, refreshRate);
scheduleJob(scheduler, Ec2InstanceRefreshJob.class, refreshRate);
scheduleJob(scheduler, Ec2SGRefreshJob.class, refreshRate);
scheduleJob(scheduler, ElasticacheRefreshJob.class, refreshRate);
scheduleJob(scheduler, ElasticsearchRefreshJob.class, refreshRate);
scheduleJob(scheduler, IamRefreshJob.class, refreshRate);
scheduleJob(scheduler, RdsRefreshJob.class, refreshRate);
scheduleJob(scheduler, SqsRefreshJob.class, refreshRate);

final JobDetail jobDetail = newJob(AWSDatabaseHolderRefreshJob.class).
withIdentity(AWSDatabaseHolderRefreshJob.NAME).
build();

scheduler.scheduleJob(jobDetail, trigger);

log.info("Creating age health check");
healthCheckRegistry.register("DB", new HealthCheck() {
Expand Down Expand Up @@ -175,4 +175,18 @@ private static void configureConnectors(Server server) {
}
}
}

private static void scheduleJob(Scheduler scheduler, Class jobClass, Long refreshRate) throws SchedulerException {
final SimpleTrigger trigger = newTrigger().
withIdentity(jobClass.toString()).
startNow().
withSchedule(simpleSchedule().withIntervalInMilliseconds(refreshRate).repeatForever()).
build();

final JobDetail jobDetail = newJob(jobClass).
withIdentity(jobClass.toString()).
build();

scheduler.scheduleJob(jobDetail, trigger);
}
}
18 changes: 18 additions & 0 deletions src/main/java/com/airbnb/billow/TimestampedData.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,18 @@
package com.airbnb.billow;

import lombok.Data;
import lombok.extern.slf4j.Slf4j;

import java.util.function.Supplier;

@Data
@Slf4j
public class TimestampedData<T> {
private final T data;
private final long timestamp;

public static <T> TimestampedData<T> withTimestamp(Supplier<T> supplier) {
long timestamp = System.currentTimeMillis();
return new TimestampedData<T>(supplier.get(), timestamp);
}
}
Original file line number Diff line number Diff line change
@@ -1,17 +1,17 @@
package com.airbnb.billow;
package com.airbnb.billow.jobs;

import com.airbnb.billow.AWSDatabaseHolder;
import com.codahale.metrics.Counter;
import org.quartz.Job;
import org.quartz.JobExecutionContext;
import org.quartz.JobExecutionException;
import org.quartz.SchedulerException;

public class AWSDatabaseHolderRefreshJob implements Job {
public abstract class BaseAWSDatabaseHolderRefreshJob implements Job {
public static final String DB_KEY = "db";
public static final String FAILURE_COUNTER_KEY = "failure_counter";
public static final String START_COUNTER_KEY = "start_counter";
public static final String SUCCESS_COUNTER_KEY = "success_counter";
public static final String NAME = "dbRefresh";

@Override
public void execute(JobExecutionContext context) throws JobExecutionException {
Expand All @@ -25,6 +25,8 @@ public void execute(JobExecutionContext context) throws JobExecutionException {
}
}

abstract void refresh(AWSDatabaseHolder dbHolder);

private void increment(String counterName, JobExecutionContext context) {
try {
((Counter) context.getScheduler().getContext().get(counterName)).inc();
Expand Down
12 changes: 12 additions & 0 deletions src/main/java/com/airbnb/billow/jobs/DynamoRefreshJob.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.airbnb.billow.jobs;

import com.airbnb.billow.AWSDatabaseHolder;

public class DynamoRefreshJob extends BaseAWSDatabaseHolderRefreshJob {
public static final String NAME = "dynamo_job";

@Override
void refresh(AWSDatabaseHolder dbHolder) {
dbHolder.refreshDynamoTables();
}
}
12 changes: 12 additions & 0 deletions src/main/java/com/airbnb/billow/jobs/Ec2InstanceRefreshJob.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.airbnb.billow.jobs;

import com.airbnb.billow.AWSDatabaseHolder;

public class Ec2InstanceRefreshJob extends BaseAWSDatabaseHolderRefreshJob {
public static final String NAME = "ec2_instance_job";

@Override
void refresh(AWSDatabaseHolder dbHolder) {
dbHolder.refreshEc2Instances();
}
}
12 changes: 12 additions & 0 deletions src/main/java/com/airbnb/billow/jobs/Ec2SGRefreshJob.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.airbnb.billow.jobs;

import com.airbnb.billow.AWSDatabaseHolder;

public class Ec2SGRefreshJob extends BaseAWSDatabaseHolderRefreshJob {
public static final String NAME = "ec2_sg_job";

@Override
void refresh(AWSDatabaseHolder dbHolder) {
dbHolder.refreshEc2SGs();
}
}
12 changes: 12 additions & 0 deletions src/main/java/com/airbnb/billow/jobs/ElasticacheRefreshJob.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.airbnb.billow.jobs;

import com.airbnb.billow.AWSDatabaseHolder;

public class ElasticacheRefreshJob extends BaseAWSDatabaseHolderRefreshJob {
public static final String NAME = "elasticache_job";

@Override
void refresh(AWSDatabaseHolder dbHolder) {
dbHolder.refreshElasticacheClusters();
}
}
12 changes: 12 additions & 0 deletions src/main/java/com/airbnb/billow/jobs/ElasticsearchRefreshJob.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.airbnb.billow.jobs;

import com.airbnb.billow.AWSDatabaseHolder;

public class ElasticsearchRefreshJob extends BaseAWSDatabaseHolderRefreshJob {
public static final String NAME = "elasticsearch_job";

@Override
void refresh(AWSDatabaseHolder dbHolder) {
dbHolder.refreshElasticsearchClusters();
}
}
12 changes: 12 additions & 0 deletions src/main/java/com/airbnb/billow/jobs/IamRefreshJob.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.airbnb.billow.jobs;

import com.airbnb.billow.AWSDatabaseHolder;

public class IamRefreshJob extends BaseAWSDatabaseHolderRefreshJob {
public static final String NAME = "iam_job";

@Override
void refresh(AWSDatabaseHolder dbHolder) {
dbHolder.refreshIamUsers();
}
}
12 changes: 12 additions & 0 deletions src/main/java/com/airbnb/billow/jobs/RdsRefreshJob.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.airbnb.billow.jobs;

import com.airbnb.billow.AWSDatabaseHolder;

public class RdsRefreshJob extends BaseAWSDatabaseHolderRefreshJob{
public static final String NAME = "rds_job";

@Override
void refresh(AWSDatabaseHolder dbHolder) {
dbHolder.refreshRdsInstances();
}
}
12 changes: 12 additions & 0 deletions src/main/java/com/airbnb/billow/jobs/SqsRefreshJob.java
Original file line number Diff line number Diff line change
@@ -0,0 +1,12 @@
package com.airbnb.billow.jobs;

import com.airbnb.billow.AWSDatabaseHolder;

public class SqsRefreshJob extends BaseAWSDatabaseHolderRefreshJob {
public static final String NAME = "sqs_job";

@Override
void refresh(AWSDatabaseHolder dbHolder) {
dbHolder.refreshSqsQueues();
}
}