Fix NPE when using ES without dedicated master (#54)

airbnb · Jan 7, 2022 · 26688f5 · 26688f5
1 parent ce9367f
commit 26688f5
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 3 deletions.
diff --git a/pom.xml b/pom.xml
@@ -6,7 +6,7 @@
 
     <groupId>com.airbnb.billow</groupId>
     <artifactId>billow</artifactId>
-    <version>2.21</version>
+    <version>2.25</version>
 
     <licenses>
         <license>

diff --git a/src/main/java/com/airbnb/billow/ElasticsearchCluster.java b/src/main/java/com/airbnb/billow/ElasticsearchCluster.java
@@ -45,7 +45,12 @@ public ElasticsearchCluster(ElasticsearchDomainStatus domainStatus, List<Tag> ta
     this.instanceCount = esConfig.getInstanceCount();
     this.dedicatedMasterEnabled = esConfig.getDedicatedMasterEnabled();
     this.zoneAwarenessEnabled = esConfig.getZoneAwarenessEnabled();
-    this.dedicatedMasterType = esConfig.getDedicatedMasterType();
-    this.dedicatedMasterCount = esConfig.getDedicatedMasterCount();
+    if (esConfig.getDedicatedMasterEnabled()) {
+      this.dedicatedMasterCount = esConfig.getDedicatedMasterCount();
+      this.dedicatedMasterType = esConfig.getDedicatedMasterType();
+    } else {
+      this.dedicatedMasterCount = 0;
+      this.dedicatedMasterType = "";
+    }
   }
 }