Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Start deleting loose nodes while packing (and commit pack index) in a safe way #173

Open
giovannipizzi opened this issue Jul 18, 2024 · 1 comment

Comments

@giovannipizzi
Copy link
Member

If the dostore container is repacked, typically all objects are first packed, and then one has to call separately the clean_storage function to remove loose objects. However, if the container is big (say 100GB+), this has a high change to end disk space.

One could provide an option to commit the sqlite DB and clean the storage as soon as a pack file is completed, so the additional required space at any time is max ~4GB (and then use it from AiiDA). Pinging @unkcpz as we discussed this together

@giovannipizzi
Copy link
Member Author

As a note, one has to be careful, however to do operations correctly, so there is no risk that a concurrent read process does not find an object at some point in time (eg, one has to commit the sqlite DB and make sure it's written to disk, before attempting any cleaning). Probably calling clean_storage is safe enough, after a commit

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant