Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

_StructureDataBaseViewer consider resetting input_selection trait when the structure is modified. #531

Open
yakutovicha opened this issue Nov 2, 2023 · 0 comments
Assignees

Comments

@yakutovicha
Copy link
Member

Currently, the issue with input_selection trait is that one cannot just assign to it a copy of the list with the same content:

selection = copy(self.input_selection)
self.input_selection = selection

This won't trigger the trait observers (not sure why 🤷 ).

So the solution we currently use is the following:

selection = copy(self.input_selection)
self.input_selection = None
self.input_selection = selection

This creates a lot of unnecessary code and increases the risk of errors. We should try to come up with a more general solution.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant