configuration_tabs option of StructureDataViewer is broken
#425
Comments
Merged
unkcpz
pushed a commit
to unkcpz/aiidalab-widgets-base
that referenced
this issue
Nov 16, 2023
) There is an issue that when the aiida-pseudo update to have the latest version of library, such as from `v1,2` to `v1.3`, since in the QeApp we hardcode the library for workchain protocol, the install command in `sssp.py` will fail because it trys to install the latest version which is `v1.3` but it not compatible with the validate version that is `v1.2`. In this commit, we also hardcode the version to the install command to make sure when a new version is available in aiida-pseudo, it will still install the correct version.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
PR #371 broke the
configuration_tabsoption of the StructureDataViewer. In the latest release, when this option is passed to the class constructure, no configuration tabs are displayed.I am pretty sure because of this deleted if statement
https://github.com/aiidalab/aiidalab-widgets-base/pull/371/files#diff-5aac3a07d48497df9963232d6dff4bbeb87f5a6992192cae0ed1eecd7d6573cdL217
Putting the
if configuration_tabs:statement back fixes the issue for me.(Note that this broke my app so putting high urgency on this...)
The text was updated successfully, but these errors were encountered: