Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Example structure SiO2 has extra tags #617

Closed
superstar54 opened this issue Feb 2, 2024 · 2 comments
Closed

Example structure SiO2 has extra tags #617

superstar54 opened this issue Feb 2, 2024 · 2 comments
Assignees
Labels
bug Something isn't working

Comments

@superstar54
Copy link
Member

Describe the bug
Feedback from a PSI user:
I tried calculating XAS spectra for SiO2 (from the example structures). The SiO2 structure gives me the error < ValueError: Error occurred validating port 'inputs.pw': The pseudos specified and structure kinds do not match: {'O', 'O1', 'Si', 'X'} vs {'O', 'Si', 'X'} >

Additional context
We should remove the tag of the SiO2 structure.

@superstar54 superstar54 added the bug Something isn't working label Feb 2, 2024
@superstar54 superstar54 self-assigned this Feb 2, 2024
@PNOGillespie
Copy link
Contributor

Hi @superstar54. Just wanted to add a few things here:

  1. I would be interested to try re-creating the error, since I'm fairly sure something like this should be fixed by (XAS: Enable Correct Parsing of Hubbard and Magnetic Data aiidateam/aiida-quantumespresso#969) but I'd like to make sure this is the case.
  2. Why does the structure have this special marker for oxygen anyway? I'm just curious about that.

SiO2 is also used in the XSpectra literature (section A of the 2009 paper), and their past tutorials, as an example for Si and O K-edge calculations. The structure used there is hexagonal, rather than the one currently in the examples which is tetragonal, so I could provide a replacement for the structure already in the AiiDALab-QE examples if we want to do that.

Let me know your thoughts on that.

@superstar54
Copy link
Member Author

The tag is removed in #518.

The structure used there is hexagonal, rather than the one currently in the examples which is tetragonal, so I could provide a replacement for the structure already in the AiiDALab-QE examples if we want to do that.

Thanks @PNOGillespie. Some structures in the example are incorrect, and @cpignedoli is working on it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants