From 79e88779d4daaef2931427ba11e80d1de9334ad2 Mon Sep 17 00:00:00 2001 From: Jendrik Seipp Date: Wed, 4 Oct 2023 22:23:55 +0200 Subject: [PATCH 1/2] Fix method names in SoPlex interface. --- src/search/lp/soplex_solver_interface.cc | 8 ++++---- 1 file changed, 4 insertions(+), 4 deletions(-) diff --git a/src/search/lp/soplex_solver_interface.cc b/src/search/lp/soplex_solver_interface.cc index a5e4dc7d10..9d2bc69f83 100644 --- a/src/search/lp/soplex_solver_interface.cc +++ b/src/search/lp/soplex_solver_interface.cc @@ -55,7 +55,7 @@ SoPlexSolverInterface::SoPlexSolverInterface() : SolverInterface() { void SoPlexSolverInterface::load_problem(const LinearProgram &lp) { for (const LPVariable &var : lp.get_variables()) { if (var.is_integer) { - cout << "SoPlex does not support integer variables" << endl; + cerr << "SoPlex does not support integer variables" << endl; utils::exit_with(utils::ExitCode::SEARCH_UNSUPPORTED); } } @@ -105,18 +105,18 @@ void SoPlexSolverInterface::set_constraint_upper_bound(int index, double bound) } void SoPlexSolverInterface::set_variable_lower_bound(int index, double bound) { - soplex.changeUpperReal(index, bound); + soplex.changeLowerReal(index, bound); } void SoPlexSolverInterface::set_variable_upper_bound(int index, double bound) { - soplex.changeLowerReal(index, bound); + soplex.changeUpperReal(index, bound); } void SoPlexSolverInterface::set_mip_gap(double /*gap*/) { /* There is nothing to do here: Soplex doesn't accept MIPs, so setting a MIP gap tolerance has no effect. We do not treat it as an error, so solvers - can be set up without cheking what problems they will eventually solve. + can be set up without checking what problems they will eventually solve. Loading a problem with integer variables will lead to an error either way. */ } From b0825c88f93a36a42ca24a80a44bcb85695d179e Mon Sep 17 00:00:00 2001 From: Jendrik Seipp Date: Wed, 4 Oct 2023 22:45:44 +0200 Subject: [PATCH 2/2] Fix typo. --- src/search/lp/soplex_solver_interface.cc | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/src/search/lp/soplex_solver_interface.cc b/src/search/lp/soplex_solver_interface.cc index 9d2bc69f83..02c7cdb228 100644 --- a/src/search/lp/soplex_solver_interface.cc +++ b/src/search/lp/soplex_solver_interface.cc @@ -114,7 +114,7 @@ void SoPlexSolverInterface::set_variable_upper_bound(int index, double bound) { void SoPlexSolverInterface::set_mip_gap(double /*gap*/) { /* - There is nothing to do here: Soplex doesn't accept MIPs, so setting a MIP + There is nothing to do here: SoPlex doesn't accept MIPs, so setting a MIP gap tolerance has no effect. We do not treat it as an error, so solvers can be set up without checking what problems they will eventually solve. Loading a problem with integer variables will lead to an error either way.