issue #46: Add every useful workflow for this repository #49
Conversation
ThomasCardin
changed the title
it's working now, but failing for another reason |
Would it be a good idea to turn this into Draft until you've fixed the failing checks? |
rngadam
changed the title
|
@ThomasCardin spelling of useful is one l |
|
|
||
| COPY ./requirements.txt . | ||
|
|
||
| RUN pip3 install --no-cache-dir -r requirements.txt | ||
|
|
||
| COPY . ./ | ||
|
|
||
| CMD hypercorn -b :$PORT app:app | ||
| CMD hypercorn -b :8080 app:app |
There was a problem hiding this comment.
PORT should stay as GCR (Google Cloud Run) expects PORT to be specifiable (although it does default to 8080).
https://cloud.google.com/run/docs/container-contract
The ingress container within an instance must listen for requests on 0.0.0.0 on the port to which requests are sent. By default, requests are sent to 8080, but you can configure Cloud Run to send requests to the port of your choice. Cloud Run injects the PORT environment variable into the ingress container.
There was a problem hiding this comment.
Okay, but we don't use GCR ❓So we don't need to keep the $PORT.
There was a problem hiding this comment.
Why would you not have this though? Seems to be a good practice to have a default value for PORT but allow it to be overriden too.
| * **NACHET_AZURE_STORAGE_CONNECTION_STRING**: Connection string to access | ||
| external storage (Azure Blob Storage). | ||
| * **NACHET_MODEL_ENDPOINT_REST_URL**: Endpoint to communicate with deployed | ||
| model for inferencing. | ||
| * **NACHET_MODEL_ENDPOINT_ACCESS_KEY**: Key used when consuming online endpoint. | ||
| * **NACHET_DATA**: Url to access nachet-data repository |
There was a problem hiding this comment.
Not related to this issue.
There was a problem hiding this comment.
we can still fix typos when we open a file. IMO, this is better than having to open PR to fix only typos. We leave things we modify in a better state than we got it.
|
@rngadam ping. I'm waiting for this pull request before I can proceed with this one: ai-cfia/howard#4. (change de default tag of the docker image inside each kubernetes deployment to |
the test is failing (lint-test step failing) |
|
Out of scope of this issue |
it is not out of scope; tests need to be green in a pull request before it gets merged. |
|
The error was coming from using a Mock object instead of a MagicMock object (to be able to use the Does this PR still need to be pushed to main, or are the workflows being pushed already? |
@ThomasCardin since this is fixed in main, this pull request should be rebased to get the tests to pass to allow for merging. |
The current workflow (build and push docker images to this organisation registry) is working but the workflow it self is missing steps.
Workflow included: