Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Docker Azure deployment action #40

Closed
wants to merge 1 commit into from
Closed

Docker Azure deployment action #40

wants to merge 1 commit into from

Conversation

ThomasCardin
Copy link
Member

@ThomasCardin ThomasCardin linked an issue Dec 3, 2023 that may be closed by this pull request
Add Azure build and push to ACR workflow #39
Closed
vivalareda
vivalareda approved these changes Dec 3, 2023
View reviewed changes
Copy link
Contributor

@vivalareda vivalareda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, iirc we fixed the lint-test with William last friday so should pass once that PR is approved

rngadam
rngadam suggested changes Dec 5, 2023
View reviewed changes
.github/workflows/azure-deployment.yml Outdated Show resolved Hide resolved
rngadam
rngadam suggested changes Dec 6, 2023
View reviewed changes
Copy link

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

rework your commit history to link to issue and provide a meaningful commit message

@ThomasCardin ThomasCardin force-pushed the 39-issue-create-the-azure-deployment branch 2 times, most recently from ac70d08 to 9cefd9a Compare January 3, 2024 19:57
@ThomasCardin ThomasCardin reopened this Jan 3, 2024
@ThomasCardin ThomasCardin force-pushed the 39-issue-create-the-azure-deployment branch from 9cefd9a to 5e9162e Compare January 3, 2024 20:03
@ThomasCardin ThomasCardin reopened this Jan 3, 2024
@ThomasCardin
Copy link
Member Author

rework your commit history to link to issue and provide a meaningful commit message

done @rngadam

@ThomasCardin
Copy link
Member Author

ThomasCardin commented Jan 3, 2024 •
edited
Loading

@rngadam

Considering that we frequently switch between cloud accounts (Azure, AWS, GCP), wouldn't it be better to simply push our images to our GitHub instead? It would allow us to stop constantly changing our credentials in the github secrets. I could take care of making the changes in the repositories if I have the green light.

@rngadam
Copy link

rngadam commented Jan 11, 2024

Considering that we frequently switch between cloud accounts (Azure, AWS, GCP), wouldn't it be better to simply push our images to our GitHub instead? It would allow us to stop constantly changing our credentials in the github secrets. I could take care of making the changes in the repositories if I have the green light.

sound reasonable

@ThomasCardin
Copy link
Member Author

Considering that we frequently switch between cloud accounts (Azure, AWS, GCP), wouldn't it be better to simply push our images to our GitHub instead? It would allow us to stop constantly changing our credentials in the github secrets. I could take care of making the changes in the repositories if I have the green light.

sound reasonable

Ok, then i'm closing this PR since we are now pushing images to the Github container registry (GCR)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rngadam rngadam rngadam requested changes

@vivalareda vivalareda vivalareda approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add Azure build and push to ACR workflow
3 participants
@ThomasCardin @rngadam @vivalareda