-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding unit test for comparing json file #4
Conversation
there's no need to put up your name in the title of PR |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
test filename has a typo whit -> with
use forward slash / instead of \ for file paths (as is convention on unix-like filesystems)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove __pycache__
folder and be carfeful, you still have a lot of camelCase variable name instead of snake_case (Java is showing 😉)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Name of the folder is not following the naming conventions
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Rename pictures to be more clear
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
empty file ? Should be deleted if not used
Co-authored-by: Maxence Guindon <[email protected]>
Make sure you resolve every requested changes before merging |
This pull request is for adding test that can calculate how many % of similitude we have between the json file test.
(Last one like this was created before implanting all the nomenclature).