Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Adding unit test for comparing json file #4

Merged
merged 21 commits into from
Apr 12, 2024
Merged

Conversation

SamuelPelletierEvraire
Copy link
Contributor

@SamuelPelletierEvraire SamuelPelletierEvraire commented Apr 3, 2024

This pull request is for adding test that can calculate how many % of similitude we have between the json file test.
(Last one like this was created before implanting all the nomenclature).

@rngadam rngadam changed the title [Samuel Pelletier-Evraire] Adding unit test for comparing json file Adding unit test for comparing json file Apr 9, 2024
@rngadam
Copy link

rngadam commented Apr 9, 2024

there's no need to put up your name in the title of PR

@SamuelPelletierEvraire SamuelPelletierEvraire marked this pull request as ready for review April 10, 2024 17:35
@SamuelPelletierEvraire SamuelPelletierEvraire requested review from a team and removed request for rngadam April 10, 2024 17:36
Copy link

@rngadam rngadam left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

test filename has a typo whit -> with
use forward slash / instead of \ for file paths (as is convention on unix-like filesystems)

Copy link
Collaborator

@MaxenceGui MaxenceGui left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remove __pycache__ folder and be carfeful, you still have a lot of camelCase variable name instead of snake_case (Java is showing 😉)

app.py Outdated Show resolved Hide resolved
app.py Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
Copy link
Collaborator

@ibrahim-kabir ibrahim-kabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Name of the folder is not following the naming conventions

.gitignore Outdated Show resolved Hide resolved
Copy link
Collaborator

@ibrahim-kabir ibrahim-kabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Rename pictures to be more clear

Copy link
Collaborator

@ibrahim-kabir ibrahim-kabir left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

empty file ? Should be deleted if not used

app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
app.py Outdated Show resolved Hide resolved
Co-authored-by: Maxence Guindon <[email protected]>
@ai-cfia ai-cfia deleted a comment from rngadam Apr 12, 2024
@SamuelPelletierEvraire SamuelPelletierEvraire requested a review from a team as a code owner April 12, 2024 18:06
@SamuelPelletierEvraire SamuelPelletierEvraire requested review from rngadam and removed request for rngadam April 12, 2024 18:36
@ThomasCardin
Copy link
Member

Make sure you resolve every requested changes before merging

@SamuelPelletierEvraire SamuelPelletierEvraire requested review from a team and removed request for a team April 12, 2024 19:03
@SamuelPelletierEvraire SamuelPelletierEvraire merged commit 68d2708 into main Apr 12, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Initial assessment of accuracy of LLM label information extraction and checklist evaluation
5 participants