Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor big if sequence with a dictionary #12

Closed
MaxenceGui opened this issue Apr 12, 2024 · 0 comments
Closed

Refactor big if sequence with a dictionary #12

MaxenceGui opened this issue Apr 12, 2024 · 0 comments

Comments

@MaxenceGui
Copy link
Collaborator

Description 🚀

Checking properties for harvester is done in a long list of if. To make the code easier to read and to maintain, I suggest the use of a dictionary and a for loop.

Steps by Steps :📋

  • Create a property dictionary as a CONSTANT (could even be an environment variable)
  • Refactor the long if using .items()
  • Validate that the program work

Effort and Impact 🏃🏻

This is not hard to implement and it will really help the code readability.

Acceptance criteria ✅

  • The program behave the same as before
@MaxenceGui MaxenceGui self-assigned this Apr 12, 2024
MaxenceGui pushed a commit that referenced this issue Apr 12, 2024
@MaxenceGui MaxenceGui linked a pull request Apr 12, 2024 that will close this issue
@MaxenceGui MaxenceGui removed their assignment Apr 25, 2024
@SamuelPelletierEvraire SamuelPelletierEvraire closed this as not planned Won't fix, can't repro, duplicate, stale May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants