Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

What are the plans for a stable release? #2

Open
kjwierenga opened this issue Feb 27, 2015 · 9 comments
Open

What are the plans for a stable release? #2

kjwierenga opened this issue Feb 27, 2015 · 9 comments

Comments

@kjwierenga
Copy link
Contributor

Most recent commit is from some time ago. I'm currently using to_json and liking it. What are your plans for a stable release on rubygems.org?

@ahacking
Copy link
Owner

I havent needed to change much as the DSL is designed to be simple but able to fully express any json structure. Mainly readme fixes.

I'd like to add full unit tests and improve the documentation before publishibg as a first class gem.

I'd also like to add support for the Oj stream writer which didn't exist when I initially created to_json. I want to give some thought to the best way this can work for streaming thousands of long lived connections eg. web sockets with something like event machine or Celluloid:IO.

I just don't have any free cycles or active project work that can sponsor the improvements right now.

PRs are welcome of course.

@xtagon
Copy link

xtagon commented Oct 1, 2015

:+1 for a release on Rubygems. I'm currently evaluating switching from ActiveModel Serializer, but is this production ready? The docs say AMS is undergoing unstable changes, but at the same time to_json doesn't even have first release.

If tests and docs are a concern, it wouldn't hurt to push v0.0.1 to Rubygems (or whatever unstable version) in the meantime.

@ahacking
Copy link
Owner

ahacking commented Oct 1, 2015

When I wrote the readme and analysis of other gems AMS was undergoing a a lot of change if may have since settled down.

to_json has been heavily used in a rails based api. I was pushing the capability, performance and memory limits with all other json gems hence writing to_json which aside from readme/doc fixes and a few minor bug fixes and enhancements hasn't really needed to change. I consider it stable and reliable code despite not being pushed onto Rubygems because I've used it in anger. There isn't a lot of code in to_json because of the way I designed it as a DSL around Oj.

I have some spare time coming up in the next week so I will endeavor to publish an official 1.0 release on rubygems, its about time really so thanks for the prompt!

@xtagon
Copy link

xtagon commented Oct 1, 2015

That sounds great :-)

@codezomb
Copy link

Any word on this? I'm loving to_json so far, but considering the activity here I'm wondering if I should keep with it, or fork it for myself and my team to pick at.

@ahacking
Copy link
Owner

I haven't forgotten and will release 1.0 very shortly, just had too many other things occupying my time.

You are very welcome to send me pull requests for any enhancements you or your team make to your own fork.

@xtagon
Copy link

xtagon commented Feb 25, 2017

@ahacking Hope you're doing well :-)

Do you think you will have time to revisit publishing to Rubygems soon? I have multiple production apps using ToJson now and they all have to reference a git repo with a specific ref hash instead of specifying a version in the Gemfile. It feels wrong.

Is there anything I can do to help you prepare the repo for publishing?

Thanks!

@ahacking
Copy link
Owner

@xtagon thanks for your interest and apologies for my slow reply, life seems to have overtaken my free time to work on things.

The main activity for an official release is setting up the test framework and defining unit tests. The examples in the readme are probably a good start to some test vectors on expected outputs.

@xtagon
Copy link

xtagon commented Oct 6, 2017

@ahacking Would you consider doing a Rubygems release, even if it is not a stable version? Multiple people are using this even though it hasn't been updated in 2 years.

I understand how open source goes, and how life gets busy :-) but it would be nice to be able to depend on a gem instead of a Github url even though there aren't unit tests yet.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants