Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release agda2hs 1.1 #203

Closed
jespercockx opened this issue Oct 11, 2023 · 8 comments
Closed

Release agda2hs 1.1 #203

jespercockx opened this issue Oct 11, 2023 · 8 comments
Assignees
Milestone

Comments

@jespercockx
Copy link
Member

Agda 2.6.4 has been released, so ideally we should release a compatible version of agda2hs soon. Before we do that I still want to look at the currently open bugs (#185 and #201) and fix them if possible.

@jespercockx jespercockx added this to the 1.1 milestone Oct 11, 2023
@jespercockx
Copy link
Member Author

I've created a release candidate which you can find here: https://hackage.haskell.org/package/agda2hs-1.0.20231012/candidate

@jmchapman @omelkonian @flupe @sarajuhosova @wcqaguxa @viktorcsimma and anyone else: If you have the time, could you give it a try to make sure it works okay for you?

@jespercockx
Copy link
Member Author

I've also created a tag for the RC here: https://github.com/agda/agda2hs/tree/v1.0.20231012

@jespercockx
Copy link
Member Author

Oh and before someone asks for a changelog, you can take a look at https://github.com/agda/agda2hs/issues?q=milestone%3A1.1 for now :)

@omelkonian
Copy link
Contributor

omelkonian commented Oct 15, 2023

  1. git checkout v1.0.20231012 && make test terminates successfully.
  2. wget https://hackage.haskell.org/package/agda2hs-1.0.20231012/candidate/agda2hs-1.0.20231012.tar.gz -O - | tar -xz && cd agda2hs-1.0.20231012 && cabal build terminates successfully, although it's a pity that we cannot do cabal test as well since we are relying on a custom-grown golden testing using the Makefile (is this how Agda does it as well?).

Looking at the previous version 1.0 on Hackage, it seems the Haddock is missing, so make sure you upload the documentation (i.e. cabal upload -d):

PACKAGE=agda2hs
curVersion=$(grep "^version" $PACKAGE.cabal | cut -d: -f2 | tr -d "[:blank:]")
prevVersion=$(git show HEAD^:$PACKAGE.cabal | grep "^version" | cut -d: -f2 | tr -d "[:blank:]")
if [[ $curVersion != $prevVersion ]]; then
  echo "Version has changed, publishing to Hackage."
  cabal new-sdist
  cabal upload -u $HACKAGE_USERNAME -p $HACKAGE_PASSWORD \
    --publish dist-newstyle/sdist/$PACKAGE-$curVersion.tar.gz
  cabal upload -u $HACKAGE_USERNAME -p $HACKAGE_PASSWORD \
    --publish -d dist-newstyle/$PACKAGE-$curVersion-docs.tar.gz
else
  echo "Version has not changed, not publishing to Hackage."
fi

@odderwiser
Copy link
Contributor

There are some braking changes for the tutorial files, I updated them accordingly: #206

@viktorcsimma
Copy link
Contributor

I think the version numbers in the Emacs mode remained 2.6.3 and Emacs complains about this. I'll fix that soon.

@viktorcsimma
Copy link
Contributor

Huh; there seems to be a bigger problem... do you have any ideas? See issue #208.

@jespercockx
Copy link
Member Author

agda2hs 1.1 has been released: https://hackage.haskell.org/package/agda2hs-1.1

@jespercockx jespercockx self-assigned this Feb 23, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants