-
Notifications
You must be signed in to change notification settings - Fork 237
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Implement ≤-total in terms of _≤?_ #2440
base: master
Are you sure you want to change the base?
Conversation
You'll need a CHANGELOG entry as it's a breaking change for people |
That's a good point, I'll add a changelog after #2439 gets merged |
I'll wait to do a proper review once the CHANGELOG is in place. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Modulo:
CHANGELOG
breaking
This looks great!
How does this PR contribute to (positively or negatively...) the issues about 'concrete' orderings raised in issue #1179 ? |
@jamesmckinna they're related, but I don't think either of them solve or get in the way of the other |
Happy to merge once there's a second 'approve' review from one of the other maintainers... and a |
I think when you resolve the merge conflict in |
The question is do we view this as a backwards compatible breaking change? If it was just a change in behaviour then I would say yes and bump it to v3.0. If however, we argue that this is in fact a performance bug then the maybe we can justify adding it to v2.2? |
@MatthewDaggitt while I would like it in sooner, of course, the position that has the better argument is that we don't make any performance guarantees at all (our readme says more or less this right near the beginning). Based on that, it probably ought wait for 3.0 |
Well, if you were to make that sacrifice, that would ease the path to a |
Fixes #2436