Add support for index and range

afxres · Jul 25, 2024 · 14a201a · 14a201a
1 parent bf01877
commit 14a201a
Show file tree

Hide file tree

Showing 6 changed files with 45 additions and 9 deletions.
diff --git a/...inary.Tests/Features/LargeIntegerTests.cs → ...Converters.Primitive/LargeIntegerTests.cs b/...inary.Tests/Features/LargeIntegerTests.cs → ...Converters.Primitive/LargeIntegerTests.cs
@@ -1,4 +1,4 @@
-namespace Mikodev.Binary.Tests.Features;
+namespace Mikodev.Binary.Tests.Converters.Primitive;
 
 using System;
 using System.Collections.Generic;

diff --git a/...Binary.Tests/Features/IntegrationTests.cs → ...ve/NativeEndianOrLittleEndianDataTests.cs b/...Binary.Tests/Features/IntegrationTests.cs → ...ve/NativeEndianOrLittleEndianDataTests.cs
@@ -1,11 +1,11 @@
-namespace Mikodev.Binary.Tests.Features;
+namespace Mikodev.Binary.Tests.Converters.Primitive;
 
 using System;
 using System.Collections.Generic;
 using System.Text;
 using Xunit;
 
-public class IntegrationTests
+public class NativeEndianOrLittleEndianDataTests
 {
     public static IEnumerable<object[]> SimpleObjectData =>
     [
@@ -45,6 +45,14 @@ public void ConverterBasicInfo(int length, object data)
         [double.NegativeInfinity],
     ];
 
+    public static IEnumerable<object[]> IndexData()
+    {
+        yield return new object[] { Index.Start };
+        yield return new object[] { Index.End };
+        yield return new object[] { Index.FromStart(2) };
+        yield return new object[] { Index.FromEnd(3) };
+    }
+
     public static IEnumerable<object[]> DateOnlyData =>
     [
         [DateOnly.MinValue],
@@ -100,6 +108,7 @@ public void ConverterBasicInfo(int length, object data)
 
     [Theory(DisplayName = "Encode Decode")]
     [MemberData(nameof(NumberData))]
+    [MemberData(nameof(IndexData))]
     [MemberData(nameof(DateOnlyData))]
     [MemberData(nameof(DateTimeOffsetData))]
     [MemberData(nameof(DateTimeData))]
@@ -127,6 +136,7 @@ public void EncodeDecode<T>(T item)
 
     [Theory(DisplayName = "Encode Decode Auto")]
     [MemberData(nameof(NumberData))]
+    [MemberData(nameof(IndexData))]
     [MemberData(nameof(DateOnlyData))]
     [MemberData(nameof(DateTimeOffsetData))]
     [MemberData(nameof(DateTimeData))]
@@ -153,6 +163,7 @@ public void EncodeDecodeAuto<T>(T item)
 
     [Theory(DisplayName = "Encode Decode With Length Prefix")]
     [MemberData(nameof(NumberData))]
+    [MemberData(nameof(IndexData))]
     [MemberData(nameof(DateOnlyData))]
     [MemberData(nameof(DateTimeOffsetData))]
     [MemberData(nameof(DateTimeData))]

diff --git a/.../Binary.Tests/Features/EndiannessTests.cs → ...ve/NativeEndianOrLittleEndianInfoTests.cs b/.../Binary.Tests/Features/EndiannessTests.cs → ...ve/NativeEndianOrLittleEndianInfoTests.cs
@@ -1,4 +1,4 @@
-namespace Mikodev.Binary.Tests.Features;
+namespace Mikodev.Binary.Tests.Converters.Primitive;
 
 using System;
 using System.Collections.Generic;
@@ -8,7 +8,7 @@
 using System.Runtime.InteropServices;
 using Xunit;
 
-public class EndiannessTests
+public class NativeEndianOrLittleEndianInfoTests
 {
     private delegate T Decode<T>(ref byte source);
 
@@ -53,9 +53,18 @@ public struct Block64 { }
         [8, 3.0],
     ];
 
+    public static IEnumerable<object[]> IndexData()
+    {
+        yield return new object[] { 4, Index.Start };
+        yield return new object[] { 4, Index.End };
+        yield return new object[] { 4, Index.FromStart(1) };
+        yield return new object[] { 4, Index.FromEnd(1) };
+    }
+
     [Theory(DisplayName = "Fallback Converter Info")]
     [MemberData(nameof(EnumData))]
     [MemberData(nameof(NumberData))]
+    [MemberData(nameof(IndexData))]
     public void FallbackConverterBasicInfo<T>(int length, T data)
     {
         var generator = Generator.CreateDefault();
@@ -71,6 +80,7 @@ public void FallbackConverterBasicInfo<T>(int length, T data)
     [Theory(DisplayName = "Internal Native Endian Converter Info")]
     [MemberData(nameof(EnumData))]
     [MemberData(nameof(NumberData))]
+    [MemberData(nameof(IndexData))]
     public void InternalNativeEndianConverterInfo<T>(int length, T data)
     {
         var creatorName = typeof(T).IsEnum ? "DetectEndianEnumConverterCreator" : "DetectEndianConverterCreator";
@@ -89,6 +99,7 @@ public void InternalNativeEndianConverterInfo<T>(int length, T data)
     [Theory(DisplayName = "Internal Little Endian Converter Info")]
     [MemberData(nameof(EnumData))]
     [MemberData(nameof(NumberData))]
+    [MemberData(nameof(IndexData))]
     public void InternalLittleEndianConverterInfo<T>(int length, T data)
     {
         var creatorName = typeof(T).IsEnum ? "DetectEndianEnumConverterCreator" : "DetectEndianConverterCreator";

diff --git a/...ers.Numerics/ConverterIntegrationTests.cs → ...iveEndianOrRepeatLittleEndianDataTests.cs b/...ers.Numerics/ConverterIntegrationTests.cs → ...iveEndianOrRepeatLittleEndianDataTests.cs
@@ -1,4 +1,4 @@
-namespace Mikodev.Binary.Tests.Converters.Numerics;
+namespace Mikodev.Binary.Tests.Converters.Primitive;
 
 using Mikodev.Binary.Tests.Contexts;
 using Mikodev.Binary.Tests.Internal;
@@ -10,8 +10,17 @@
 using System.Runtime.InteropServices;
 using Xunit;
 
-public class ConverterIntegrationTests
+public class NativeEndianOrRepeatLittleEndianDataTests
 {
+    public static IEnumerable<object[]> RangeData()
+    {
+        yield return new object[] { Range.All };
+        yield return new object[] { Range.StartAt(Index.FromStart(2)) };
+        yield return new object[] { Range.StartAt(Index.FromEnd(3)) };
+        yield return new object[] { Range.EndAt(Index.FromStart(4)) };
+        yield return new object[] { Range.EndAt(Index.FromEnd(5)) };
+    }
+
     public static IEnumerable<object[]> ComplexData()
     {
         yield return new object[] { Complex.Zero };
@@ -77,6 +86,7 @@ public static IEnumerable<object[]> Vector4Data()
     }
 
     [Theory(DisplayName = "Encode Decode")]
+    [MemberData(nameof(RangeData))]
     [MemberData(nameof(ComplexData))]
     [MemberData(nameof(Matrix3x2Data))]
     [MemberData(nameof(Matrix4x4Data))]
@@ -101,6 +111,7 @@ public void EncodeDecode<T>(T data) where T : unmanaged
     }
 
     [Theory(DisplayName = "Encode Decode Multiple")]
+    [MemberData(nameof(RangeData))]
     [MemberData(nameof(ComplexData))]
     [MemberData(nameof(Matrix3x2Data))]
     [MemberData(nameof(Matrix4x4Data))]

diff --git a/...onverters.Numerics/ConverterBasicTests.cs → ...iveEndianOrRepeatLittleEndianInfoTests.cs b/...onverters.Numerics/ConverterBasicTests.cs → ...iveEndianOrRepeatLittleEndianInfoTests.cs
@@ -1,4 +1,4 @@
-namespace Mikodev.Binary.Tests.Converters.Numerics;
+namespace Mikodev.Binary.Tests.Converters.Primitive;
 
 using Mikodev.Binary.Tests.Internal;
 using System;
@@ -8,13 +8,14 @@
 using System.Reflection;
 using Xunit;
 
-public class ConverterBasicTests
+public class NativeEndianOrRepeatLittleEndianInfoTests
 {
     [Fact(DisplayName = "Shared Converters With Known Types")]
     public void SharedConverters()
     {
         var knownTypes = new[]
         {
+            typeof(Range),
             typeof(Complex),
             typeof(Matrix3x2),
             typeof(Matrix4x4),

diff --git a/code/Binary/Creators.Endianness/DetectEndianConverterCreator.cs b/code/Binary/Creators.Endianness/DetectEndianConverterCreator.cs
@@ -42,10 +42,12 @@ static void RegisterRepeat<T, E>(Dictionary<Type, ConverterPair> dictionary) whe
         Register<float>(dictionary);
         Register<double>(dictionary);
         Register<Half>(dictionary);
+        Register<Index>(dictionary);
         Register<BitVector32>(dictionary);
         Register<Int128>(dictionary);
         Register<UInt128>(dictionary);
 
+        RegisterRepeat<Range, int>(dictionary);
         RegisterRepeat<Complex, double>(dictionary);
         RegisterRepeat<Matrix3x2, float>(dictionary);
         RegisterRepeat<Matrix4x4, float>(dictionary);