Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Don't show irrelevant properties of a component based on the schema constraint #762

Open
vincentfretin opened this issue Sep 2, 2024 · 0 comments
Open

Don't show irrelevant properties of a component based on the schema constraint #762

vincentfretin opened this issue Sep 2, 2024 · 0 comments

Comments

@vincentfretin
Copy link
Contributor

Changing groundColor of pointLight gives an error at line
at
https://github.com/aframevr/aframe/blob/80dd9507dc5ff615e8ca0d38df838cbb87eca052/src/components/light.js#L84
on

light.groundColor.set(value);

with light.groundColor undefined because that exists only for hemisphere.

The right panel shouldn't show the groundColor property, it should take into account the constraint defined in schema to show the properties
https://github.com/aframevr/aframe/blob/80dd9507dc5ff615e8ca0d38df838cbb87eca052/src/components/light.js#L22

    groundColor: {type: 'color', if: {type: ['hemisphere']}},
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@vincentfretin