Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Radial hash ignores gamma parameter? #22

Open
ChernyshevDS opened this issue Aug 13, 2020 · 1 comment
Open

Radial hash ignores gamma parameter? #22

ChernyshevDS opened this issue Aug 13, 2020 · 1 comment

Comments

@ChernyshevDS
Copy link

Looking at ph_image_digest function, I've discovered the following line:

(graysc / graysc.max()).pow(gamma);

It seems for me, that this line doesn't do anything, because graysc.max() returns scalar value, and operator/(const T value) returns new image instance. pow method is called on that instance, but it doesn't make any difference, because the result is not assigned anywhere.
Am I missing something there?

@eklinger
Copy link
Collaborator

eklinger commented Aug 13, 2020 via email

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants