-
Notifications
You must be signed in to change notification settings - Fork 21
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add components overview tool like Storybook. #972
Comments
We have been used Storybook in the Base aepp. It was useful in developing some common components. But we were frequently accidentally breaking the components from there. So, it requires some additional maintenance. |
@davidyuk What means |
I mean, making a change in a component you have to check how it looks in Storybook even if it looks not necessary. Otherwise, a Storybook page may become broken and unusable. But maybe it can be checked automatically somehow. |
@davidyuk what if I create some test to check that? |
At least it can be a test with node.js that parse files:
|
but it can be overhead due some components include other sub-components as parts that doesn't mean much without parent component. so maybe it can be some manually tracked list of components... |
I think the script can just open each storybook page in the browser and ensure that there are no exceptions. |
I suggest such test with node.js:
|
It can be done with Cypress. |
But I'm still not sure how to automatically get the list of the all components. Because sometimes one component include other and some of them are useless without the parent one and I'm not sure hot to determinate that programatically. |
@davidyuk the main problem with such test is to find out what components are needs to be included in the Storybook and which are pages or the parts of other components that are useless without parent component. |
I don't think so. As I know, Storybook renders only pages defined by the developer, to check them script just needs to open each one. It shouldn't care about which components are referenced on these pages. |
I understand that but I want to find the answer for that question:
|
Why do you need that? |
You mean only to check if Storybook is not broken? I thought to check if all components are present at the Storybook. |
So if to check only if Storybook is not broken it's pretty easy. |
@davidyuk as far as I can see together we finally formalize this task in:
I will assign this task to myself. |
I'm proposing to add some pages as well. Ensure that this is approved before starting to work on it. |
@davidyuk what exactly that pages is about? |
Actually, they are called stories. See the example in the Base aepp repo. |
It will be good to have components overview tool like Storybook. Because from time to time project is on maintenance, also that's pretty handy for the check the whole rebranding and overview the all components.
Storybook's blog post:
Code examples:
Video example:
The text was updated successfully, but these errors were encountered: