Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cordova stuff rebased on top of develop with some optimisations #156

Merged
merged 10 commits into from
Jul 5, 2018

Conversation

davidyuk
Copy link
Member

@davidyuk davidyuk commented Jun 27, 2018

It is based on #130.

For some reason, latest versions of cordova-icon and cordova-splash are not working: AlexDisler/cordova-icon#118 (comment).
splash-icon.png image is broken, it has a black dot at right bottom side, maybe @raymundjacobs can provide a better one, also splash screen looks vertically deformed on my mobile phone, but it is okay in the emulator.

This PR is depends on changes in aeternity/hd-wallet-js#1.

@davidyuk davidyuk force-pushed the feature/cordova-davidyuk branch 2 times, most recently from 6a47234 to 9d62c1b Compare June 27, 2018 16:10
@davidyuk davidyuk force-pushed the feature/cordova-davidyuk branch 5 times, most recently from 268a78f to d37fbb8 Compare June 28, 2018 10:48
@davidyuk davidyuk requested a review from dadaphl June 28, 2018 10:58
@davidyuk davidyuk force-pushed the feature/cordova-davidyuk branch 2 times, most recently from 625346c to 33f4cad Compare July 4, 2018 01:40
@davidyuk davidyuk force-pushed the feature/cordova-davidyuk branch from 33f4cad to 3308c96 Compare July 4, 2018 06:31
Copy link
Contributor

@dadaphl dadaphl left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok

@davidyuk davidyuk merged commit 8da16dd into develop Jul 5, 2018
@davidyuk davidyuk deleted the feature/cordova-davidyuk branch July 5, 2018 05:53
@davidyuk davidyuk mentioned this pull request Jul 5, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants