Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Why filter gene sets after calculating AUC? #40

Open
maddygriz opened this issue May 25, 2023 · 0 comments
Open

Why filter gene sets after calculating AUC? #40

maddygriz opened this issue May 25, 2023 · 0 comments

Comments

@maddygriz
Copy link

Hi,

Thank you for creating an awesome package. I was optimizing my workflow using this package and noticed in our spatial data that only has 1k targets we were throwing out most of the gene sets from our gmt. Digging into your code, I noticed that these gene sets are removed after calculating the AUC.
I added a preemptive filtering step to our gmt that mimics your default filtering and was able to cut hours off our pathway step. I know this was built for full transcriptome scRNA-seq data and not 1k targets so you wouldn't have expected this level of filtering but is there a reason for filtering after doing the calculations and not before the bulk of the function?

Thanks,
Maddy

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant