Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

can's save() in AergoKeyStore #11

Open
hayarobi opened this issue Aug 2, 2021 · 2 comments
Open

can's save() in AergoKeyStore #11

hayarobi opened this issue Aug 2, 2021 · 2 comments

Comments

@hayarobi
Copy link
Member

hayarobi commented Aug 2, 2021

Can't save an aergoKey in file based keystore (class hera.keystore.AergoKeyStore) if that identity is not in keystore directory.
It looks like a bug, since In-memory keystore operates exactly the opposite.

@acktsap
Copy link
Contributor

acktsap commented Aug 11, 2021

Can you explain more precisely? It seems to work fine.

FYI, AergoKeyStore is compatible with keystore created by aergocli (it looks examples are not updated yet)

@hayarobi
Copy link
Member Author

hayarobi commented Dec 2, 2021

(This answer is translated by papago from original Korean answer)
If you load a keystore file that already contains a wallet and add a new wallet to that keystore, it will cause an error. It can be added exactly, but errors occur in the process of saving.

Was it the save() method? In it, we found that the logic of examining already existing key stores was the opposite of the memory-based keystore and the file-based keystore.


이미 지갑이 들어있는 키스토어 파일을 로딩한 다음, 해당 키스토어에 새 지갑을 추가하면 에러가 납니다. 정확히는 추가는 되지만 저장을 하는 과정에서 에러가 납니다.

save()메서드였나? 그 안에서 이미 존재하는 키스토어 검사하는 로직이 메모리 기반 키스토어와 파일 기반 키스토어가 정 반대로 되어 있는 것을 발견했습니다.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants