-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Issue/639 #950
Issue/639 #950
Conversation
Hi @ryuuzake, just providing some updates: I have added some changes to handle initial/pre-pop in https://github.com/aehrc/smart-forms/commits/issue/639/. After that I also want to add changes so that it works with calculatedExpression with unit - handling of Quantity datatype in fhirpath http://hl7.org/fhirpath/N1/#quantity. I can't quite finish it today, hopefully I get to finish it tomorrow. |
# Conflicts: # apps/smart-forms-app/package.json # package-lock.json
Hi @ryuuzake, See konsulin-care/smart-forms@issue/639...aehrc:smart-forms:issue/639 I've added the following changes:
If it looks good, can you merge it into your branch? I'll give it one last review and merge it into |
Oops, I forgot I will need to update the documentation as well. |
# Conflicts: # apps/smart-forms-app/package.json # package-lock.json # packages/smart-forms-renderer/package.json
Added documentation for the Quantity component. I've merged main into this branch a couple times now, so the conflicts might get nasty. Let me know how it goes and I'll see if there's an alternative solution. |
Hi @fongsean I'll try to check on the changes later tonight. If everything checks out, I'll resolve the conflict and merge it. Hopefully this PR can soon be accepted to the |
Hi @fongsean |
Thanks @ryuuzake! |
Resolves #639
Here some proves that the components works