Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Notifications aren't invoked again if their scheduledTime elapsed while Clippings not in use #509

Open
aecreations opened this issue Oct 28, 2024 · 2 comments
Assignees
Labels

Comments

@aecreations
Copy link
Owner

aecreations commented Oct 28, 2024

Clippings 7.0rc4

While testing backup reminder notifications, it was discovered that if Clippings was not in use (e.g. because the computer was asleep) at the time it was supposed to be invoked (represented by the scheduledTime property on the alarm that calls the background script function to perform notification processing), the alarm is never invoked again, causing the notification to be suppressed.

Note that this situation is different from when the background script is terminated. In this case, the background script is restarted when the alarm is invoked.

Is this a bug with the Alarms API when used in a non-persistent MV3 background script?

@aecreations aecreations self-assigned this Oct 28, 2024
@aecreations aecreations added this to the 7.0.1 Alcatraz milestone Nov 13, 2024
@aecreations
Copy link
Owner Author

This should be fixed for backup reminders and Sync Clippings Helper update notifications.

The post-upgrade notifications are lower priority, since their appearance is intended to be less frequent (once a day, maximum 2 invocations).

@aecreations
Copy link
Owner Author

I ran a test using a test extension that fires an alarm every 5 minutes. Even if the computer was suspended when the alarm is due to fire, the alarm continues to fire at 5 minute intervals once the computer was resumed. This was tested on Firefox 115 ESR, 132 and 133.

The issue likely is in the code that calculates whether or not to show the backup notification based on the last backup reminder date.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant